Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Allow resizing of doxygen side-nav #20511

Merged
merged 1 commit into from
Mar 27, 2024
Merged

doc: Allow resizing of doxygen side-nav #20511

merged 1 commit into from
Mar 27, 2024

Conversation

Remmirad
Copy link

Contribution description

Fixes the bug that the side-nav on RIOT-doxygen website can not be resized (in Firefox) (See #20414).

Testing procedure

Open https://doc.riot-os.org/ and try to resize the side-nav on the left (using Firefox).

Issues/PRs references

Closes #20414

doc: Allow resizing of side-nav
084c42c 
Currently it is not possible to resize the side-nav of the RIOT doxygen website in firefox.
This is caused by the window resize_handler being called even for resizing inside the window.
The resize_handler resets the side-nav to a cached size preventing resizing. This commit fixes
this by checking if the window was actually resized.
@github-actions github-actions bot added the Area: doc Area: Documentation label Mar 27, 2024
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 27, 2024
@riot-ci
Copy link

riot-ci commented Mar 27, 2024

Murdock results

✔️ PASSED

084c42c doc: Allow resizing of side-nav

Success Failures Total Runtime
1 0 1 14s

Artifacts

@maribu maribu enabled auto-merge March 27, 2024 12:58
@maribu maribu added this pull request to the merge queue Mar 27, 2024
@maribu
Copy link
Member

maribu commented Mar 27, 2024 •
edited
Loading

Thanks for the quick fix and congratulation for getting the first PR to RIOT upstream 🍰

@maribu
Copy link
Member

maribu commented Mar 27, 2024

I was made aware that you already have contributed to riot-wrappers. Sorry for the confusion and thanks for the continuous help ❤️

@miri64 miri64 added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Mar 27, 2024
@benpicco benpicco removed this pull request from the merge queue due to a manual request Mar 27, 2024
@benpicco benpicco added this pull request to the merge queue Mar 27, 2024
Merged via the queue into RIOT-OS:master with commit 1b4f45f Mar 27, 2024
29 checks passed
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
@maribu maribu mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.

Allow resizing of the side-nav (in Firefox)
7 participants
@Remmirad @riot-ci @maribu @miri64 @benpicco @MrKevinWeiss @mguetschow